perf: improve FlagDependencyExportsPlugin for large JSON by depth #8802
+232
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
release: performance
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
hai-x
force-pushed
the
hai-x/feat-support-dyn-exp-for-url
branch
from
84ce1e2 to
cad432f
Compare
CodSpeed Performance ReportMerging #8802 will not alter performanceComparing Summary
|
ahabhgk
reviewed
Dec 23, 2024
| @@ -13,13 +13,15 @@ pub struct JsonExportsDependency { | |||
| id: DependencyId, | |||
| #[cacheable(with=AsPreset)] | |||
| data: JsonValue, | |||
| exports_depth: f64, | |||
There was a problem hiding this comment.
Suggested change
| exports_depth: f64, | |
| exports_depth: u32, |
u32 should be enough
| @@ -32,7 +32,9 @@ mod utils; | |||
|
|
|||
| #[cacheable] | |||
| #[derive(Debug)] | |||
| struct JsonParserAndGenerator; | |||
| struct JsonParserAndGenerator { | |||
| pub exports_depth: f64, | |||
There was a problem hiding this comment.
Suggested change
| pub exports_depth: f64, | |
| pub exports_depth: u32, |
| D( | ||
| module.parser[JSON_MODULE_TYPE], | ||
| "exportsDepth", | ||
| mode === "development" ? 1 : Number.POSITIVE_INFINITY |
There was a problem hiding this comment.
Suggested change
| mode === "development" ? 1 : Number.POSITIVE_INFINITY | |
| mode === "development" ? 1 : Number.MAX_SAFE_INTEGER |
There was a problem hiding this comment.
It is Infinity in webpack. Should we align?
There was a problem hiding this comment.
I think both is fine, but I'm not sure what will pass to rust side by napi-rs if we use Infinity here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Aligned with webpack/webpack#19058.
I will update doc later.
Checklist